etseidl commented on code in PR #8445:
URL: https://github.com/apache/arrow-rs/pull/8445#discussion_r2382587409
##########
parquet/src/file/metadata/thrift_gen.rs:
##########
@@ -135,8 +137,8 @@ struct FileMetaData<'a> {
5: optional list<KeyValue> key_value_metadata
6: optional string created_by
7: optional list<ColumnOrder> column_orders;
- 8: optional EncryptionAlgorithm<'a> encryption_algorithm
- 9: optional binary<'a> footer_signing_key_metadata
+ 8: optional EncryptionAlgorithm encryption_algorithm
Review Comment:
The lifetime annotations signal the macros to generate slices rather than
vectors. While implementing write I found I couldn't keep the references alive
long enough to use slices, so for now encryption requires more allocations than
strictly necessary. I'd hate to duplicate all these structs to have one for
reading and one for writing.
Perhaps if we figure out a way to encapsulate the encryption code more, we
can revisit this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
