rok commented on code in PR #47586:
URL: https://github.com/apache/arrow/pull/47586#discussion_r2382071351
##########
cpp/src/arrow/sparse_tensor_test.cc:
##########
@@ -413,6 +413,99 @@ TEST_F(TestSparseCOOTensor, TestToTensor) {
ASSERT_TRUE(tensor.Equals(*dense_tensor));
}
+template <typename ValueType>
+class TestSparseCOOTensorCreationFromNegativeZero
+ : public TestSparseTensorBase<ValueType> {
+ public:
+ using ValueCType = typename ValueType::c_type;
+
+ void SetUp() override { type_ = TypeTraits<ValueType>::type_singleton(); }
+
+ void FromVector() {
+ std::vector<ValueCType> data{
+ -0.0, -0.0, 0.0, -0.0, 4.0, -0.0, -0.0, 0.0, -0.0, -1.0, -0.0, -0.0,
Review Comment:
So something like:
```cpp
std::vector<ValueCType> data{
-0.0, -0.0, 0.0, 1.0, 2.0,
-0.0, 4.0, -0.0, -0.0, +0.0,
-0.0, 0.0, +0.0, 3.0, 4.0,
-1.0, -0.0, -0.0, -0.0, -0.0,
};
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
