pitrou commented on code in PR #47586:
URL: https://github.com/apache/arrow/pull/47586#discussion_r2410441049


##########
cpp/src/arrow/tensor/converter.h:
##########
@@ -63,5 +66,56 @@ Result<std::shared_ptr<Tensor>> 
MakeTensorFromSparseCSCMatrix(
 Result<std::shared_ptr<Tensor>> MakeTensorFromSparseCSFTensor(
     MemoryPool* pool, const SparseCSFTensor* sparse_tensor);
 
+template <typename Converter>
+struct ConverterVisitor {

Review Comment:
   If at all possible. You should not include an internal header from a 
non-internal header.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to