andygrove commented on a change in pull request #10078:
URL: https://github.com/apache/arrow/pull/10078#discussion_r615398347
##########
File path: rust/datafusion/src/physical_plan/sort.rs
##########
@@ -56,7 +63,12 @@ impl SortExec {
expr: Vec<PhysicalSortExpr>,
input: Arc<dyn ExecutionPlan>,
) -> Result<Self> {
- Ok(Self { expr, input })
+ Ok(Self {
+ expr,
+ input,
+ output_rows: SQLMetric::counter("outputRows"),
+ sort_time_nanos: SQLMetric::time_nanos("sortTime"),
Review comment:
Does this imply adding an enum for the metrics? This might limit
extensibility for users that want to add custom metrics.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
