etseidl commented on PR #8476: URL: https://github.com/apache/arrow-rs/pull/8476#issuecomment-3348930333
Thanks @alamb. I'll get started on cleaning this PR up a bit more. > My one final question is "are we pretty close to merging in the thrift-remodel branch"? If so I would like to try and test the upgrade with DataFusion (and invite any other significant users of parquet to do the same) to make sure there isn't something crazy we missed. I believe that this PR is the "end of the beginning". The big breaking changes should be done. I have some experimental perf improvements, and perhaps some more tailored macros depending on where we want to go (for instance, some of the new structs are only used on the decoding side, so there's really no need to generate the write code). So, yes, I think we're pretty close to being able to merge. I still need to use this code to read the parquet files I have on hand, but hopefully the unit tests have caught most of the glaring bugs. I am very curious to see how these changes play out with DataFusion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
