etseidl commented on code in PR #8476:
URL: https://github.com/apache/arrow-rs/pull/8476#discussion_r2389459496
##########
parquet/src/file/metadata/writer.rs:
##########
@@ -317,7 +317,7 @@ impl<'a, W: Write> ThriftMetadataWriter<'a, W> {
/// 4. Length of encoded `FileMetaData` (4 bytes, little endian)
/// 5. Parquet Magic Bytes (4 bytes)
///
-/// [`FileMetaData`]: crate::format::FileMetaData
+/// [`FileMetaData`]:
https://github.com/apache/parquet-format/tree/master?tab=readme-ov-file#metadata
Review Comment:
Rather than linking to this crate's `FileMetaData` struct here, I think the
discussion above could be expanded to note that `ParquetMetaData` does not map
directly to the thrift structures defined in the specification. We could then
direct to the metadata module docs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
