etseidl commented on code in PR #8476: URL: https://github.com/apache/arrow-rs/pull/8476#discussion_r2389463726
########## parquet/src/file/page_index/column_index.rs: ########## @@ -17,7 +17,7 @@ //! [`ColumnIndexMetaData`] structures holding decoded [`ColumnIndex`] information //! -//! [`ColumnIndex`]: crate::format::ColumnIndex +//! [`ColumnIndex`]: https://github.com/apache/parquet-format/blob/master/PageIndex.md Review Comment: I've updated this (and the matching docs in `offset_index.rs`) to point to the page index docs in the metadata module in https://github.com/apache/arrow-rs/pull/8476/commits/8454d5083832d83688ec49da21667f578a28cd19 ########## parquet/src/parquet_macros.rs: ########## @@ -20,13 +20,22 @@ // They allow for pasting sections of the Parquet thrift IDL file // into a macro to generate rust structures and implementations. -// TODO(ets): These macros need a good bit of documentation so other developers will be able -// to use them correctly. Also need to write a .md file with complete examples of both how -// to use the macros, and how to implement custom readers and writers when necessary. +//! This is a collection of macros used to parse Thrift IDL descriptions of structs, Review Comment: done in https://github.com/apache/arrow-rs/pull/8476/commits/8454d5083832d83688ec49da21667f578a28cd19 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
