pitrou commented on code in PR #47599:
URL: https://github.com/apache/arrow/pull/47599#discussion_r2426490764
##########
cpp/src/arrow/dataset/dataset_writer.cc:
##########
@@ -383,8 +383,11 @@ class DatasetWriterDirectoryQueue
}
init_future_ = Future<>::Make();
auto create_dir_cb = [this] {
- return
DeferNotOk(write_options_.filesystem->io_context().executor()->Submit(
- [this]() { return write_options_.filesystem->CreateDir(directory_);
}));
+ return DeferNotOk(
Review Comment:
This entire code path is not executed if `create_dir` is false (see `if`
clause at the beginning of this function), so I'm not sure why you need to
change this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
