andishgar commented on PR #47586: URL: https://github.com/apache/arrow/pull/47586#issuecomment-3397874554
@pitrou One thing you might have overlooked during your code review is that the `IndexPointer` and `Index` can have different types. Therefore, `VisitCSXType` must support both types. However, during `SparseTensor` creation from a `Tensor` via the `Make` method, the current interface only supports a single type for both the IndexPointer and the Index. It’s still possible, though, to create a `SparseTensor` via its constructor with different types for `IndexPointer` and `Index`. Thus, it’s crucial to have a visit method that handles three types for sparse tensor validation. However, it’s not necessary to visit three types during the tensor-to-sparse-tensor conversion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
