etseidl commented on code in PR #8599: URL: https://github.com/apache/arrow-rs/pull/8599#discussion_r2427340566
########## parquet/src/file/metadata/thrift/mod.rs: ########## @@ -174,8 +184,8 @@ fn convert_bounding_box( } /// Create a [`crate::file::statistics::Statistics`] from a thrift [`Statistics`] object. -pub(crate) fn convert_stats( - physical_type: Type, +fn convert_stats( Review Comment: I have a branch where this becomes `read_stats` and avoids the intermediate `Statistics<'a>` struct, but that didn't move the needle much on performance. I'll revisit this later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
