etseidl opened a new pull request, #8599: URL: https://github.com/apache/arrow-rs/pull/8599
# Which issue does this PR close? - Part of #5853. # Rationale for this change Earlier work had introduced some code duplication dealing with decoding of the `ColumnMetaData` Thrift struct. This PR addresses that, and also addresses earlier review comments (https://github.com/apache/arrow-rs/pull/8587#discussion_r2421703047). # What changes are included in this PR? This PR changes how some metadata structures are parsed, utilizing a flag for required fields rather than relying on `Option::is_some`. This allows for passing around partially initialized `ColumnChunkMetaData` structs which in turn allows for sharing of the `ColumnMetaData` parsing code between the encrypted and unencrypted code paths. This PR also moves the `file/metadata/{encryption,thrift_gen}.rs` files to a new `file::metadata::thrift` module. # Are these changes tested? Covered by existing tests. # Are there any user-facing changes? No, only makes changes to private APIs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
