klion26 commented on code in PR #8638:
URL: https://github.com/apache/arrow-rs/pull/8638#discussion_r2438641209
##########
parquet-variant-compute/src/variant_array.rs:
##########
@@ -920,17 +921,12 @@ fn typed_value_to_variant<'a>(
panic!("Invalid variant, conflicting value and typed_value");
}
match data_type {
+ DataType::Null => Variant::Null,
DataType::Boolean => {
let boolean_array = typed_value.as_boolean();
let value = boolean_array.value(index);
Variant::from(value)
}
- DataType::Date32 => {
Review Comment:
This has been adjusted to be grouped together with the Timestamp/Time.
##########
parquet-variant-compute/src/variant_to_arrow.rs:
##########
@@ -545,3 +557,21 @@ impl VariantToBinaryVariantArrowRowBuilder {
Ok(ArrayRef::from(variant_array))
}
}
+
+trait AppendValueTrait {
+ // NullBuilder will always append `()`
+ fn append_value(&mut self, v: ());
+}
+
+impl AppendValueTrait for NullBuilder {
Review Comment:
The function is needed by the `define_variant_to_primitive_builder` macro.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
