scovich commented on code in PR #8625:
URL: https://github.com/apache/arrow-rs/pull/8625#discussion_r2432827098
##########
parquet-variant-compute/src/variant_array.rs:
##########
@@ -439,6 +440,20 @@ impl From<VariantArray> for ArrayRef {
}
}
+impl<'m, 'v> FromIterator<Option<Variant<'m, 'v>>> for VariantArray {
Review Comment:
If we do this:
```suggestion
impl<'m, 'v, V: Into<Variant<'m, 'v>> FromIterator<Option<V>> for
VariantArray {
```
then we can create a variant array from anything that converts cleanly to
variant (e.g. i64 values or &str)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
