friendlymatthew commented on PR #8625: URL: https://github.com/apache/arrow-rs/pull/8625#issuecomment-3406748448
> LGTM! > > > I'll throw in the other `impl From` in the second commit > > I'm not sure this is needed? `VariantArray::from_iterator` is pretty clear, and a `VariantArray::from` wouldn't be able to do anything smarter (can't just take ownership of the vec's data, for example) Yeah, I agree. I'll just remove the second impl From -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
