raulcd commented on code in PR #47627:
URL: https://github.com/apache/arrow/pull/47627#discussion_r2389934580
##########
cpp/src/arrow/flight/CMakeLists.txt:
##########
@@ -231,6 +231,17 @@ foreach(LIB_TARGET ${ARROW_FLIGHT_LIBRARIES})
target_compile_definitions(${LIB_TARGET} PRIVATE ARROW_FLIGHT_EXPORTING)
endforeach()
+# Handle Unity build header conflicts on Windows
Review Comment:
Yes, I wasn't able to find out what the problematic source file was with all
my tests. Non-unity builds works well, I tested different things and the only
thing I found to work was to force include those headers. I would love to
upgrade our vcpkg version now that this works for all wheels (mainly because of
the outdated version and the fix to the macos wheels).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
