kou commented on code in PR #47627:
URL: https://github.com/apache/arrow/pull/47627#discussion_r2389903618
##########
cpp/src/arrow/flight/CMakeLists.txt:
##########
@@ -231,6 +231,17 @@ foreach(LIB_TARGET ${ARROW_FLIGHT_LIBRARIES})
target_compile_definitions(${LIB_TARGET} PRIVATE ARROW_FLIGHT_EXPORTING)
endforeach()
+# Handle Unity build header conflicts on Windows
Review Comment:
Hmm... The error message doesn't include source file information...
In general, we should skip unity build for the target source files by
`SKIP_UNITY_BUILD_INCLUSION TRUE` like
https://github.com/apache/arrow/blob/13c2615f6772eda028c57f5f99bdcbf708126ff0/cpp/src/arrow/flight/CMakeLists.txt#L122-L124
.
But the error message doesn't provide hints for the target source files...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
