birschick-bq commented on PR #3315: URL: https://github.com/apache/arrow-adbc/pull/3315#issuecomment-3325572225
> Thanks! > > Perhaps it's because there's no good way to name things that's not overly generic, but I'm a bit confused about the current split into assemblies and how things depend on each other. What's the difference between "Exporters" and "Listeners"? "Exporters" depends on "Listeners" but nothing depends on "Listeners"? > > Anyhow, a few minor changes requested. @CurtHagenlocher I created a `Listeners` project to be a more "light-weight' version without needing the OTel libraries. The `Listeners` library uses the `System.Diagnostics.ActivityListener` directly. Also, as we not have a filter mechanism, we can match the lifetimes of the tracing with the Connection. Downside is that the trace files will be smaller and more numerous because they won't be any sharing among multiple Connections in the same process. Since much of the code for file listener is the same as the file exporter, I chose to make Exporter dependent on Listeners. Currently, there is no (known) consumer of the Exporter assembly/library. I didn't remove it for backwards compatibility reasons. The Exporters library/assembly is meant to support OTLP (and console) tracing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
