birschick-bq commented on code in PR #3315: URL: https://github.com/apache/arrow-adbc/pull/3315#discussion_r2373447190
########## csharp/test/Telemetry/Traces/Listeners/FileListener/FileActivityListenerTests.cs: ########## @@ -0,0 +1,157 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +using System.Diagnostics; +using Apache.Arrow.Adbc.Telemetry.Traces.Listeners; +using Apache.Arrow.Adbc.Telemetry.Traces.Listeners.FileListener; +using Apache.Arrow.Adbc.Tracing; +using Apache.Arrow.Ipc; + +namespace Apache.Arrow.Adbc.Tests.Telemetry.Traces.Listeners.FileListener +{ + public class FileActivityListenerTests + { + private const string TraceLocation = "adbc.trace.location"; + + [Theory] + [InlineData(null, false)] + [InlineData("", false)] + [InlineData(" ", false)] + [InlineData(ListenersOptions.Exporters.None, false)] + [InlineData(ListenersOptions.Exporters.AdbcFile, true)] + public void TestTryActivateFileListener(string? exporterOption, bool expected) + { + Assert.Equal(expected, FileActivityListener.TryActivateFileListener("TestSource", exporterOption, out FileActivityListener? listener)); + Assert.True(expected == (listener != null)); + listener?.Dispose(); + } + + [Fact] + public async Task CanTraceConcurrentConnections() + { + const int numConnections = 5; + const int numActivitiesPerConnection = 1000; + string folderLocation = Path.Combine(Environment.GetFolderPath(Environment.SpecialFolder.LocalApplicationData), TracingFileTests.NewName()); + + try + { + TestConnection[] connections = new TestConnection[numConnections]; + for (int i = 0; i < numConnections; i++) + { + connections[i] = new TestConnection(new Dictionary<string, string> + { + { ListenersOptions.Exporter, ListenersOptions.Exporters.AdbcFile }, + { TraceLocation, folderLocation }, + }); Review Comment: fixed ########## csharp/src/Telemetry/Traces/Listeners/FileListener/TracingFile.cs: ########## @@ -122,6 +126,8 @@ private async Task WriteSingleLineAsync(Stream stream) await OpenNewTracingFileAsync().ConfigureAwait(false); } await stream.CopyToAsync(_currentFileStream).ConfigureAwait(false); + // In case of a crash, flush to disk. Review Comment: changed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
