westonpace commented on a change in pull request #10061:
URL: https://github.com/apache/arrow/pull/10061#discussion_r616025045
##########
File path: cpp/src/arrow/dataset/scanner.h
##########
@@ -152,6 +152,9 @@ class ARROW_DS_EXPORT ScanTask {
/// resulting from the Scan. Execution semantics are encapsulated in the
/// particular ScanTask implementation
virtual Result<RecordBatchIterator> Execute() = 0;
Review comment:
Correct. These methods can go away when `SyncScanner` goes away.
Removing the `ScanTask` bindings won't be enough (although I'm happy to hear
they are removed) because `SyncScanner::ToTable` and the synchronous dataset
write both rely on scanning being safe to call (ala nested deadlock) from a CPU
executor thread.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
