lidavidm commented on a change in pull request #10061:
URL: https://github.com/apache/arrow/pull/10061#discussion_r616204782
##########
File path: cpp/src/arrow/dataset/file_base.cc
##########
@@ -480,20 +479,14 @@ Status FileSystemDataset::Write(const
FileSystemDatasetWriteOptions& write_optio
#endif
WriteState state(write_options);
- auto res = internal::RunSynchronously<arrow::detail::Empty>(
- [&](internal::Executor* cpu_executor) -> Future<> {
- return WriteInternal(*scanner->options(), state, std::move(scan_tasks),
- cpu_executor);
- },
- scanner->options()->use_threads);
- RETURN_NOT_OK(res);
+ RETURN_NOT_OK(WriteInternal(*scanner->options(), state,
std::move(scan_tasks)));
auto task_group = scanner->options()->TaskGroup();
for (const auto& part_queue : state.queues) {
task_group->Append([&] { return part_queue.second->writer()->Finish(); });
}
return task_group->Finish();
-}
+} // namespace dataset
Review comment:
nit: was this intentional?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
