Dandandan commented on a change in pull request #11:
URL: https://github.com/apache/arrow-datafusion/pull/11#discussion_r616117438



##########
File path: datafusion/tests/sql.rs
##########
@@ -1289,14 +1289,46 @@ async fn equijoin_implicit_syntax_reversed() -> 
Result<()> {
 }
 
 #[tokio::test]
-async fn cartesian_join() -> Result<()> {
-    let ctx = create_join_context("t1_id", "t2_id")?;
+async fn cross_join() -> Result<()> {
+    let mut ctx = create_join_context("t1_id", "t2_id")?;

Review comment:
       Added some extra test cases for multiple partitions




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to