tustvold commented on code in PR #503:
URL:
https://github.com/apache/arrow-rs-object-store/pull/503#discussion_r2428202146
##########
src/gcp/mod.rs:
##########
@@ -114,6 +115,127 @@ struct UploadState {
parts: Parts,
}
+#[derive(Debug)]
+struct ResumableState {
+ client: Arc<GoogleCloudStorageClient>,
+ session_uri: String,
+ in_flight: AtomicUsize,
+ next_offset: AtomicU64,
+ closed: AtomicBool,
+}
+
+#[derive(Debug)]
+struct GCSResumableUpload {
+ state: Arc<ResumableState>,
Review Comment:
I wonder if we could use
https://docs.rs/tokio/latest/tokio/sync/struct.Notify.html to serialise the
uploads, I think this would be more in keeping with the design than erroring if
polled concurrently
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
