james-rms commented on code in PR #503:
URL:
https://github.com/apache/arrow-rs-object-store/pull/503#discussion_r2432106905
##########
src/gcp/mod.rs:
##########
@@ -114,6 +115,127 @@ struct UploadState {
parts: Parts,
}
+#[derive(Debug)]
+struct ResumableState {
+ client: Arc<GoogleCloudStorageClient>,
+ session_uri: String,
+ in_flight: AtomicUsize,
+ next_offset: AtomicU64,
+ closed: AtomicBool,
+}
+
+#[derive(Debug)]
+struct GCSResumableUpload {
+ state: Arc<ResumableState>,
Review Comment:
We could, but i'm not sure if it's in keeping with the design enough to not
break something. I was worried about applications that try to do parallel
upload and being surprised that most of their tasks are stalled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
