WilliamWhispell commented on a change in pull request #10106:
URL: https://github.com/apache/arrow/pull/10106#discussion_r616629187
##########
File path: go/arrow/array/builder.go
##########
@@ -277,6 +277,8 @@ func NewBuilder(mem memory.Allocator, dtype arrow.DataType)
Builder {
case arrow.UNION:
case arrow.DICTIONARY:
case arrow.MAP:
+ typ := dtype.(*arrow.MapType)
Review comment:
Looks like in this change, you're only adding map support, but here you
are changing union and dictionary to use the map builder. I'm not sure in this
context the difference between map and dictionary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
