zeroshade commented on a change in pull request #10106:
URL: https://github.com/apache/arrow/pull/10106#discussion_r616674653
##########
File path: go/arrow/array/builder.go
##########
@@ -277,6 +277,8 @@ func NewBuilder(mem memory.Allocator, dtype arrow.DataType)
Builder {
case arrow.UNION:
case arrow.DICTIONARY:
case arrow.MAP:
+ typ := dtype.(*arrow.MapType)
Review comment:
you're still thinking in C++ context. Go doesn't automatically
fallthrough like C++, this *only* modifies the Map case, it doesn't change
anything about Union or Dictionary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
