ion-elgreco commented on code in PR #512:
URL:
https://github.com/apache/arrow-rs-object-store/pull/512#discussion_r2444064240
##########
src/aws/credential.rs:
##########
@@ -423,6 +423,10 @@ fn canonicalize_headers(header_map: &HeaderMap) ->
(String, String) {
let mut value_bytes = 0;
let mut key_bytes = 0;
+ fn normalize_whitespace(s: &str) -> String {
+ s.split_whitespace().collect::<Vec<_>>().join(" ")
Review Comment:
Well split_whitespace does that as well, since if it's a single whitespace,
joining it later it will have a single whitespace again.
Looking at the Minio implementation in Go, they also replace other unicode
characters :
https://github.com/minio/minio/blob/05e569960ac584c8927a9af76755708d20f16129/cmd/signature-v4-utils_test.go#L307-L324
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
