ion-elgreco commented on code in PR #512:
URL:
https://github.com/apache/arrow-rs-object-store/pull/512#discussion_r2444118828
##########
src/aws/credential.rs:
##########
@@ -452,7 +456,7 @@ fn canonicalize_headers(header_map: &HeaderMap) -> (String,
String) {
if value_idx != 0 {
canonical_headers.push(',');
}
- canonical_headers.push_str(value.trim());
+ canonical_headers.push_str(&normalize_whitespace(value));
Review Comment:
@tustvold I've updated the code to push the strs directly in `&mut headers`
and not allocate the Vec, hope thats fine?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
