scovich commented on code in PR #7307:
URL: https://github.com/apache/arrow-rs/pull/7307#discussion_r2445582645
##########
parquet/src/file/metadata/mod.rs:
##########
@@ -700,7 +708,11 @@ impl RowGroupMetaData {
}
/// Method to convert from Thrift.
- pub fn from_thrift(schema_descr: SchemaDescPtr, mut rg: RowGroup) ->
Result<RowGroupMetaData> {
+ pub fn from_thrift(
+ schema_descr: SchemaDescPtr,
+ mut rg: RowGroup,
+ first_row_number: Option<i64>,
Review Comment:
If this lands in arrow-57, it can be a breaking change. Otherwise... agree
we need to be careful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
