friendlymatthew commented on code in PR #8673:
URL: https://github.com/apache/arrow-rs/pull/8673#discussion_r2448807842
##########
parquet-variant-compute/src/variant_array.rs:
##########
@@ -910,70 +968,72 @@ impl StructArrayBuilder {
/// returns the non-null element at index as a Variant
fn typed_value_to_variant<'a>(
- typed_value: &'a ArrayRef,
+ typed_value: &'a TypedValue,
value: Option<&BinaryViewArray>,
index: usize,
) -> Variant<'a, 'a> {
- let data_type = typed_value.data_type();
+ let (_typed_value_field, typed_value_column) = typed_value;
Review Comment:
Now that we have the field information, we can check for extension types
like:
https://github.com/apache/arrow-rs/pull/8673/commits/e21dc1b63789c45d6bfb505d444c6d0031766bc3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
