paleolimbot commented on code in PR #8673:
URL: https://github.com/apache/arrow-rs/pull/8673#discussion_r2456449485
##########
parquet-variant-compute/src/variant_array.rs:
##########
@@ -708,6 +730,9 @@ impl From<ShreddedVariantFieldArray> for StructArray {
}
}
+pub type TypedValue = (FieldRef, ArrayRef);
Review Comment:
Probably `struct TypedArrayRef { value: ArrayRef, field: FieldRef }` is best
for now (keeping the `FieldRef`-is-a-type bit opaque). Using FieldRefs as types
in DataFusion has mostly led to a lot of cloned metadata and heterogeneity with
respect to how the name/metadata/nullability should propagate (or not) but it
does seem to be the path of least resistance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
