adamreeve commented on PR #8671: URL: https://github.com/apache/arrow-rs/pull/8671#issuecomment-3430702271
Changing this back to draft as I realised the handling of `FileDecryptor::footer_decryptor` isn't correct and I'm not sure yet exactly how to handle this. The implementation of `HeapSize` for `Arc<T>` looks wrong, this should match the implementation for `Box` where the size of the contained item is included. But even if that's fixed, the `Arc` impl isn't used for an `Arc<dyn BlockDecryptor>`. Instead the Arc is dereferenced and only the `HeapSize` implementation of the contained type is used. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
