etseidl commented on code in PR #8671:
URL: https://github.com/apache/arrow-rs/pull/8671#discussion_r2460419391
##########
parquet/src/file/metadata/mod.rs:
##########
@@ -1907,16 +1912,90 @@ mod tests {
.build();
#[cfg(not(feature = "encryption"))]
- let bigger_expected_size = 2674;
+ let bigger_expected_size = 3192;
Review Comment:
So sad to see this increase so much. Truth hurts 😢
##########
parquet/src/schema/types.rs:
##########
@@ -845,7 +845,9 @@ pub struct ColumnDescriptor {
impl HeapSize for ColumnDescriptor {
fn heap_size(&self) -> usize {
- self.primitive_type.heap_size() + self.path.heap_size()
+ // Don't include the heap size of primitive_type, this is already
+ // accounted for via SchemaDescriptor::schema
+ self.path.heap_size()
Review Comment:
🚀
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
