CurtHagenlocher commented on code in PR #3608:
URL: https://github.com/apache/arrow-adbc/pull/3608#discussion_r2453306143
##########
csharp/src/Drivers/BigQuery/BigQueryStatement.cs:
##########
@@ -738,6 +737,7 @@ protected override void Dispose(bool disposing)
this.readers = null;
this.cancellationContext.Dispose();
}
+ this.cancellationContext.Dispose();
Review Comment:
Line 738 is now redundant
##########
csharp/src/Drivers/BigQuery/BigQueryStatement.cs:
##########
@@ -663,10 +664,7 @@ public void CancelAll()
public void Dispose()
{
- foreach (CancellationContext context in contexts.Keys)
- {
- context.Dispose();
- }
+ // Clear the registry and let holder of the contexts dispose
themselves
Review Comment:
The comment seems to describe the reason for this change, but without the
context of the previously-checked-in version it doesn't seem helpful for
understanding the code moving forward.
What does it mean for the context to dispose itself?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
