birschick-bq commented on code in PR #3608:
URL: https://github.com/apache/arrow-adbc/pull/3608#discussion_r2453341450


##########
csharp/src/Drivers/BigQuery/BigQueryStatement.cs:
##########
@@ -663,10 +664,7 @@ public void CancelAll()
 
             public void Dispose()
             {
-                foreach (CancellationContext context in contexts.Keys)
-                {
-                    context.Dispose();
-                }
+                // Clear the registry and let holder of the contexts dispose 
themselves

Review Comment:
   @CurtHagenlocher 
   
   Modified to implement a more robust dispose on the ContextRegistry. Removed 
unnecessary comment.
   
   Does this make better sense?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to