a10y commented on code in PR #8645:
URL: https://github.com/apache/arrow-rs/pull/8645#discussion_r2455844678
##########
arrow-select/src/filter.rs:
##########
@@ -1370,6 +1396,60 @@ mod tests {
assert_eq!(&make_array(expected), &result);
}
+ #[test]
+ fn test_filter_list_view_array() {
+ // [[1, 2], null, [], [3,4]]
+ let mut list_array =
ListViewBuilder::with_capacity(Int32Builder::with_capacity(6), 4);
+ list_array.append_value([Some(1), Some(2)]);
+ list_array.append_null();
+ list_array.append_value([]);
+ list_array.append_value([Some(3), Some(4)]);
+
+ let list_array = list_array.finish();
+ let predicate = BooleanArray::from_iter([true, true, false, true]);
+
+ // Filter result: [[1, 2], null, [3, 4]]
Review Comment:
i integrated it into one test that filters both null and non-null elements.
Good call, found a bug 👀
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
