a10y commented on code in PR #8645:
URL: https://github.com/apache/arrow-rs/pull/8645#discussion_r2456352751
##########
arrow-data/src/equal/mod.rs:
##########
@@ -104,10 +105,9 @@ fn equal_values(
byte_view_equal(lhs, rhs, lhs_start, rhs_start, len)
}
DataType::List(_) => list_equal::<i32>(lhs, rhs, lhs_start, rhs_start,
len),
- DataType::ListView(_) | DataType::LargeListView(_) => {
- unimplemented!("ListView/LargeListView not yet implemented")
- }
DataType::LargeList(_) => list_equal::<i64>(lhs, rhs, lhs_start,
rhs_start, len),
+ DataType::ListView(_) => list_view_equal::<i32>(lhs, rhs, lhs_start,
rhs_start, len),
+ DataType::LargeListView(_) => list_view_equal::<i64>(lhs, rhs,
lhs_start, rhs_start, len),
Review Comment:
I couldn't find any tests at all in this module. I could write some just for
list_view, where do you think they should be?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
