liamzwbao commented on code in PR #8689:
URL: https://github.com/apache/arrow-rs/pull/8689#discussion_r2458321122
##########
arrow-cast/src/cast/decimal.rs:
##########
@@ -166,50 +166,86 @@ where
}
}
-pub(crate) fn convert_to_smaller_scale_decimal<I, O>(
- array: &PrimitiveArray<I>,
+/// Construct closures to upscale decimals from `(input_precision,
input_scale)` to
+/// `(output_precision, output_scale)`.
Review Comment:
I added docs for the return types. Specifically, `f_infallible` is
guaranteed to be valid when provided; otherwise it will be None, and the caller
should fall back to `f_fallible` for casting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
