liamzwbao commented on code in PR #8689:
URL: https://github.com/apache/arrow-rs/pull/8689#discussion_r2457675166
##########
arrow-cast/src/cast/decimal.rs:
##########
@@ -223,24 +259,49 @@ where
O::Native::from_decimal(adjusted)
};
- Ok(if is_infallible_cast {
- // make sure we don't perform calculations that don't make sense w/o
validation
- validate_decimal_precision_and_scale::<O>(output_precision,
output_scale)?;
Review Comment:
If we add it, it will be inside `apply_decimal_cast`, so it remains an
internal implementation detail and will not cross the code path with the public
API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
