martin-g commented on code in PR #8696:
URL: https://github.com/apache/arrow-rs/pull/8696#discussion_r2460005333
##########
arrow-buffer/src/util/bit_iterator.rs:
##########
@@ -71,6 +72,71 @@ impl Iterator for BitIterator<'_> {
let remaining_bits = self.end_offset - self.current_offset;
(remaining_bits, Some(remaining_bits))
Review Comment:
Not related to this PR but shouldn't the first item in the tuple return
`self.current_offset` ?
According to
https://doc.rust-lang.org/std/iter/trait.Iterator.html#method.size_hint -
`size_hint() returns a tuple where the first element is the lower bound, and
the second element is the upper bound.`
Update: ignore that. My confusion!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
