martin-g commented on code in PR #8696:
URL: https://github.com/apache/arrow-rs/pull/8696#discussion_r2460028202
##########
arrow-buffer/src/util/bit_iterator.rs:
##########
@@ -86,6 +152,27 @@ impl DoubleEndedIterator for BitIterator<'_> {
let v = unsafe { get_bit_raw(self.buffer.as_ptr(), self.end_offset) };
Some(v)
}
+
+ fn nth_back(&mut self, n: usize) -> Option<Self::Item> {
+ // Check if we advance to the one before the desired offset
Review Comment:
```suggestion
// Check if we advance to the one before the desired offset.
```
##########
arrow-buffer/src/util/bit_iterator.rs:
##########
@@ -86,6 +152,27 @@ impl DoubleEndedIterator for BitIterator<'_> {
let v = unsafe { get_bit_raw(self.buffer.as_ptr(), self.end_offset) };
Some(v)
}
+
+ fn nth_back(&mut self, n: usize) -> Option<Self::Item> {
+ // Check if we advance to the one before the desired offset
+ // when n is 0 it means we want the next_back() value
Review Comment:
```suggestion
// When n is 0 it means we want the next_back() value
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
