peasee commented on code in PR #517:
URL:
https://github.com/apache/arrow-rs-object-store/pull/517#discussion_r2463159855
##########
src/lib.rs:
##########
@@ -1035,6 +1054,84 @@ impl GetOptions {
}
Ok(())
}
+
+ /// Create a new [`GetOptions`]
+ #[must_use]
+ pub fn new() -> Self {
+ Self::default()
+ }
+
+ /// Sets the `if_match` condition.
+ ///
+ /// See [`GetOptions::if_match`]
+ #[must_use]
+ pub fn with_if_match(mut self, etag: impl Into<String>) -> Self {
Review Comment:
Actually, I thought about this some more and I think setting as an option
does make more sense mainly because if you're setting an etag from a prior
request (like the use case for
https://github.com/apache/datafusion/issues/18211, or use cases that list files
and then retrieve them) the data type in `ObjectMeta` is already an option. The
chain becomes simpler then, because you don't have to unwrap the option and can
just clone it directly into the builder.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
