alamb commented on code in PR #517:
URL:
https://github.com/apache/arrow-rs-object-store/pull/517#discussion_r2463694086
##########
src/lib.rs:
##########
@@ -634,22 +657,196 @@ pub trait ObjectStore: std::fmt::Display + Send + Sync +
Debug + 'static {
) -> Result<Box<dyn MultipartUpload>>;
/// Return the bytes that are stored at the specified location.
+ ///
+ /// ## Example
+ ///
+ /// This example uses a basic local filesystem object store to get an
object.
+ ///
+ /// ```ignore-wasm32
Review Comment:
I was worried that tests marked with `ignore-wasm32` aren't actually tested
in rust tests
However, I made a deliberate mistake
```diff
diff --git a/src/lib.rs b/src/lib.rs
index e37fb69..0a2b815 100644
--- a/src/lib.rs
+++ b/src/lib.rs
@@ -701,6 +701,7 @@ pub trait ObjectStore: std::fmt::Display + Send + Sync +
Debug + 'static {
/// # use tempfile::tempdir;
/// # use object_store::{path::Path, ObjectStore, GetOptions};
/// async fn get_opts_example() {
+ /// XXX
/// let tmp = tempdir().unwrap();
/// let store =
LocalFileSystem::new_with_prefix(tmp.path()).unwrap();
/// let location = Path::from("example.txt");
```
And then ran `cargo test`
And it failed as expected 👍
```
---- src/lib.rs - ObjectStore::get_opts (line 699) stdout ----
error: expected `;`, found keyword `let`
--> src/lib.rs:705:4
|
9 | XXX
| ^ help: add `;` here
10 | let tmp = tempdir().unwrap();
| --- unexpected token
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
