mapleFU commented on code in PR #8694:
URL: https://github.com/apache/arrow-rs/pull/8694#discussion_r2464436183
##########
arrow-array/src/array/byte_view_array.rs:
##########
@@ -1404,6 +1463,55 @@ mod tests {
}
}
+ #[test]
+ fn test_gc_huge_array() {
Review Comment:
Previous code would meet bug only when buffer greater than 4GiB, the current
code can be tested when > 2GiB. Personally I think leave 2GiB for test is ok
but 4GiB is also ok to me, decide on reviewer's idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
