mapleFU commented on code in PR #8694:
URL: https://github.com/apache/arrow-rs/pull/8694#discussion_r2471518637
##########
arrow-array/src/array/byte_view_array.rs:
##########
@@ -512,18 +512,71 @@ impl<T: ByteViewType + ?Sized> GenericByteViewArray<T> {
};
}
- // 3) Allocate exactly capacity for all non-inline data
- let mut data_buf = Vec::with_capacity(total_large);
+ struct GcCopyGroup {
Review Comment:
I think this would making the fast path slower 🤔, a single copy-group is
just as simple as previous code. Maybe I should just remove the allocation here
( https://github.com/apache/arrow-rs/pull/8694/files#r2470787503 )?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
