alamb commented on code in PR #8729:
URL: https://github.com/apache/arrow-rs/pull/8729#discussion_r2475600254
##########
parquet/src/encodings/rle.rs:
##########
@@ -321,14 +321,15 @@ impl RleDecoder {
}
#[inline]
- pub fn set_data(&mut self, data: Bytes) {
+ pub fn set_data(&mut self, data: Bytes) -> Result<()> {
if let Some(ref mut bit_reader) = self.bit_reader {
bit_reader.reset(data);
} else {
self.bit_reader = Some(BitReader::new(data));
}
- let _ = self.reload();
+ self.reload()?;
Review Comment:
> ignores the result less obviously
I think I am going crazy -- this PR changes the function signature to return
a `Result` and then calls `self.reload()?`
I thought the `?` propagates the error now.
How is the error ignored 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
