liamzwbao commented on code in PR #8729:
URL: https://github.com/apache/arrow-rs/pull/8729#discussion_r2475721650
##########
parquet/src/arrow/record_reader/definition_levels.rs:
##########
@@ -131,9 +131,12 @@ impl DefinitionLevelBufferDecoder {
impl ColumnLevelDecoder for DefinitionLevelBufferDecoder {
type Buffer = DefinitionLevelBuffer;
- fn set_data(&mut self, encoding: Encoding, data: Bytes) {
+ fn set_data(&mut self, encoding: Encoding, data: Bytes) -> Result<()> {
match &mut self.decoder {
- MaybePacked::Packed(d) => d.set_data(encoding, data),
+ MaybePacked::Packed(d) => {
+ d.set_data(encoding, data);
+ Ok(())
+ }
MaybePacked::Fallback(d) => d.set_data(encoding, data),
}
Review Comment:
This will trigger Clippy: passing a unit value to a function. But the
following works:
```rs
match &mut self.decoder {
MaybePacked::Packed(d) => d.set_data(encoding, data),
MaybePacked::Fallback(d) => d.set_data(encoding, data)?,
};
Ok(())
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
