vegarsti commented on code in PR #8735:
URL: https://github.com/apache/arrow-rs/pull/8735#discussion_r2478058768
##########
arrow-cast/src/cast/list.rs:
##########
@@ -50,6 +50,15 @@ pub(crate) fn cast_single_element_fixed_size_list_to_values(
cast_with_options(values, to, cast_options)
}
+pub(crate) fn cast_list_to_list_view<OffsetSize>(array: &dyn Array) ->
Result<ArrayRef, ArrowError>
+where
+ OffsetSize: OffsetSizeTrait,
+{
+ let list = array.as_list::<OffsetSize>();
+ let list_view: GenericListViewArray<OffsetSize> = list.clone().into();
Review Comment:
This uses a new `From` impl, but the other way doesn't. Is that too
inconsistent? I found both patterns in the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
