vegarsti commented on code in PR #8735:
URL: https://github.com/apache/arrow-rs/pull/8735#discussion_r2480896293
##########
arrow-cast/src/cast/mod.rs:
##########
@@ -153,7 +153,16 @@ pub fn can_cast_types(from_type: &DataType, to_type:
&DataType) -> bool {
(List(list_from) | LargeList(list_from), FixedSizeList(list_to, _)) =>
{
can_cast_types(list_from.data_type(), list_to.data_type())
}
+ (List(list_from) | LargeList(list_from), ListView(list_to) |
LargeListView(list_to)) => {
+ can_cast_types(list_from.data_type(), list_to.data_type())
+ }
(List(_), _) => false,
+ (ListView(list_from), List(list_to)) => {
+ can_cast_types(list_from.data_type(), list_to.data_type())
+ }
+ (LargeListView(list_from), LargeList(list_to)) => {
+ can_cast_types(list_from.data_type(), list_to.data_type())
+ }
Review Comment:
I forgot to simplify this branch, will do
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
