mapleFU commented on PR #8694:
URL: https://github.com/apache/arrow-rs/pull/8694#issuecomment-3474198190

   @alamb I've ran the new code on MacOS M4 Pro. Don't know whether the 
performance comes from unstable environment or other
   
   <details> 
   
   This patch:
   
   ```
   view types slice        time:   [112.32 ns 112.44 ns 112.56 ns]
   Found 3 outliers among 100 measurements (3.00%)
     2 (2.00%) low severe
     1 (1.00%) low mild
   
   gc view types all[100000]
                           time:   [246.89 µs 249.22 µs 251.63 µs]
   Found 8 outliers among 100 measurements (8.00%)
     4 (4.00%) low mild
     4 (4.00%) high mild
   
   gc view types slice half[100000]
                           time:   [79.469 µs 81.771 µs 84.060 µs]
   Found 1 outliers among 100 measurements (1.00%)
     1 (1.00%) high mild
   
   gc view types all without nulls[100000]
                           time:   [406.50 µs 411.58 µs 417.23 µs]
   Found 14 outliers among 100 measurements (14.00%)
     9 (9.00%) high mild
     5 (5.00%) high severe
   
   gc view types slice half without nulls[100000]
                           time:   [373.40 µs 379.37 µs 385.93 µs]
   Found 2 outliers among 100 measurements (2.00%)
     1 (1.00%) high mild
     1 (1.00%) high severe
   
   gc view types all[8000] time:   [11.603 µs 11.663 µs 11.729 µs]
   Found 3 outliers among 100 measurements (3.00%)
     3 (3.00%) high mild
   
   gc view types slice half[8000]
                           time:   [9.4269 µs 10.204 µs 11.012 µs]
   Found 15 outliers among 100 measurements (15.00%)
     13 (13.00%) low severe
     2 (2.00%) low mild
   
   gc view types all without nulls[8000]
                           time:   [27.001 µs 27.155 µs 27.368 µs]
   Found 9 outliers among 100 measurements (9.00%)
     5 (5.00%) high mild
     4 (4.00%) high severe
   
   gc view types slice half without nulls[8000]
                           time:   [13.570 µs 13.594 µs 13.621 µs]
   Found 4 outliers among 100 measurements (4.00%)
     1 (1.00%) low severe
     2 (2.00%) high mild
     1 (1.00%) high severe
   ```
   
   main:
   
   ```
   view types slice        time:   [118.73 ns 121.33 ns 124.80 ns]
                           change: [+16.208% +20.497% +25.223%] (p = 0.00 < 
0.05)
                           Performance has regressed.
   Found 2 outliers among 100 measurements (2.00%)
     2 (2.00%) high mild
   
   gc view types all[100000]
                           time:   [175.56 µs 177.37 µs 179.60 µs]
                           change: [-26.662% -25.460% -24.243%] (p = 0.00 < 
0.05)
                           Performance has improved.
   Found 2 outliers among 100 measurements (2.00%)
     1 (1.00%) high mild
     1 (1.00%) high severe
   
   gc view types slice half[100000]
                           time:   [76.242 µs 76.520 µs 76.843 µs]
                           change: [-2.6612% -0.4692% +1.8536%] (p = 0.69 > 
0.05)
                           No change in performance detected.
   Found 10 outliers among 100 measurements (10.00%)
     3 (3.00%) high mild
     7 (7.00%) high severe
   
   gc view types all without nulls[100000]
                           time:   [385.38 µs 393.14 µs 401.00 µs]
                           change: [-3.7465% -2.3347% -0.8310%] (p = 0.00 < 
0.05)
                           Change within noise threshold.
   Found 12 outliers among 100 measurements (12.00%)
     5 (5.00%) low mild
     4 (4.00%) high mild
     3 (3.00%) high severe
   
   gc view types slice half without nulls[100000]
                           time:   [422.70 µs 426.62 µs 430.63 µs]
                           change: [+2.9492% +5.2722% +7.6808%] (p = 0.00 < 
0.05)
                           Performance has regressed.
   Found 6 outliers among 100 measurements (6.00%)
     1 (1.00%) low mild
     4 (4.00%) high mild
     1 (1.00%) high severe
   
   gc view types all[8000] time:   [16.079 µs 17.457 µs 18.815 µs]
                           change: [+47.350% +57.679% +66.216%] (p = 0.00 < 
0.05)
                           Performance has regressed.
   
   gc view types slice half[8000]
                           time:   [14.127 µs 15.144 µs 16.037 µs]
                           change: [+26.202% +34.352% +42.179%] (p = 0.00 < 
0.05)
                           Performance has regressed.
   Found 9 outliers among 100 measurements (9.00%)
     9 (9.00%) low mild
   
   gc view types all without nulls[8000]
                           time:   [27.309 µs 28.280 µs 29.285 µs]
                           change: [-2.8581% -1.0174% +0.8766%] (p = 0.29 > 
0.05)
                           No change in performance detected.
   Found 15 outliers among 100 measurements (15.00%)
     1 (1.00%) low mild
     3 (3.00%) high mild
     11 (11.00%) high severe
   
   gc view types slice half without nulls[8000]
                           time:   [15.009 µs 15.857 µs 16.825 µs]
   ```
   
   </details> 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to