wyatt-herkamp commented on code in PR #526:
URL:
https://github.com/apache/arrow-rs-object-store/pull/526#discussion_r2483803699
##########
src/lib.rs:
##########
@@ -1098,6 +1098,106 @@ macro_rules! as_ref_impl {
as_ref_impl!(Arc<dyn ObjectStore>);
as_ref_impl!(Box<dyn ObjectStore>);
+macro_rules! as_ref_generic_impl {
Review Comment:
Well, if we remove the implementation for `Arc<dyn ...>` and `Box<dyn ...>`,
anyone who uses those implementations might have a problem.
Merging the macros isn't breaking. But removing those existing
implementations might cause issues
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
